Skip to content

Conversation

hmstepanek
Copy link
Contributor

Overview

Add support for w3c traceparent sampled flag. See agent spec for details.

Copy link

github-actions bot commented Aug 13, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 6 0 0 0.76s
✅ MARKDOWN markdownlint 7 0 0 0 1.28s
✅ MARKDOWN markdown-link-check 7 0 0 18.37s
✅ PYTHON ruff 937 0 0 0 0.88s
✅ PYTHON ruff-format 937 0 0 0 0.36s
✅ YAML prettier 13 0 0 0 1.39s
✅ YAML v8r 13 0 0 6.08s
✅ YAML yamllint 13 0 0 0.64s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing Tests failing in CI. label Aug 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.45%. Comparing base (39f101c) to head (1249c7c).

Files with missing lines Patch % Lines
newrelic/api/transaction.py 90.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1448      +/-   ##
==========================================
+ Coverage   81.42%   81.45%   +0.02%     
==========================================
  Files         209      209              
  Lines       23709    23737      +28     
  Branches     3740     3745       +5     
==========================================
+ Hits        19306    19334      +28     
  Misses       3146     3146              
  Partials     1257     1257              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hmstepanek hmstepanek force-pushed the add-w3c-traceparent-header-support branch 2 times, most recently from 9df984c to 8a24ae6 Compare August 19, 2025 00:20
@hmstepanek hmstepanek force-pushed the add-w3c-traceparent-header-support branch from 8a24ae6 to bd981c4 Compare August 19, 2025 00:21
@hmstepanek hmstepanek marked this pull request as ready for review August 19, 2025 00:21
@hmstepanek hmstepanek requested a review from a team as a code owner August 19, 2025 00:21
@mergify mergify bot removed the tests-failing Tests failing in CI. label Aug 19, 2025
@hmstepanek hmstepanek force-pushed the add-w3c-traceparent-header-support branch from 3be0999 to 971ede6 Compare August 19, 2025 17:08
@hmstepanek hmstepanek requested a review from TimPansino August 21, 2025 23:26
@mergify mergify bot added the tests-failing Tests failing in CI. label Aug 21, 2025
Copy link
Contributor

@TimPansino TimPansino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bunch of places where the imports are screwed up now due to moving that validator, I'll stop reviewing there and let you re-check those.

mergify bot and others added 9 commits September 2, 2025 21:52
* Use legacy bitnami for now

* Revert solr change

* Revert zookeeper change
* Add graphene-django instrumentation

* Increase naming priority

* Remove unused import

* Add sychronous schema tests

* Clean up test files

* Remove commented out code

* Megalinter fixes

* Add operation & resolver tests

* Refine tests

* MegaLinter fixes

* Suggested reviewer changes

* Megalinter fixes
…lic/newrelic-python-agent into add-w3c-traceparent-header-support
@mergify mergify bot removed the tests-failing Tests failing in CI. label Sep 4, 2025
@TimPansino TimPansino merged commit e6b1046 into main Sep 4, 2025
60 checks passed
@TimPansino TimPansino deleted the add-w3c-traceparent-header-support branch September 4, 2025 19:43
@umaannamalai umaannamalai added this to the v10.17.0 milestone Sep 4, 2025
lrafeei added a commit that referenced this pull request Sep 12, 2025
* Add config settings

* Add traceparent logic

* Log warning if value is not recognized

* Move & rename function_not_called

* Use existing function called validators

* Fixup: lint log message

* Fixup: validator import paths

* Fixup: validator import path

* Fixup: validator import path

* Reformat w/ ruff

* Use legacy bitnami for now (#1471)

* Use legacy bitnami for now

* Revert solr change

* Revert zookeeper change

* Add graphene-django instrumentation (#1451)

* Add graphene-django instrumentation

* Increase naming priority

* Remove unused import

* Add sychronous schema tests

* Clean up test files

* Remove commented out code

* Megalinter fixes

* Add operation & resolver tests

* Refine tests

* MegaLinter fixes

* Suggested reviewer changes

* Megalinter fixes

* Fixup: paths

* Fixup: reformat lint changes

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Lalleh Rafeei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants