Skip to content

Conversation

umaannamalai
Copy link
Contributor

This PR removes wrapping for the method options on the async ES client. This method does not need to be wrapped in a DatastoreTrace since it is focused on modifying the client with custom config rather than conducting any datastore operations/ requests. The previous instrumentation caused a crash because the wrapper was expecting all client methods to be async but options is actually a sync method.

Copy link

github-actions bot commented Sep 2, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 6 0 0 0.86s
✅ MARKDOWN markdownlint 7 0 0 0 1.17s
✅ MARKDOWN markdown-link-check 7 0 0 17.54s
✅ PYTHON ruff 937 0 0 0 0.94s
✅ PYTHON ruff-format 937 0 0 0 0.31s
✅ YAML prettier 13 0 0 0 1.38s
✅ YAML v8r 13 0 0 5.66s
✅ YAML yamllint 13 0 0 0.61s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing Tests failing in CI. label Sep 2, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.44%. Comparing base (1a2fe33) to head (30d2625).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1477   +/-   ##
=======================================
  Coverage   81.43%   81.44%           
=======================================
  Files         209      209           
  Lines       23744    23744           
  Branches     3745     3745           
=======================================
+ Hits        19337    19339    +2     
+ Misses       3152     3150    -2     
  Partials     1255     1255           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot removed the tests-failing Tests failing in CI. label Sep 4, 2025
@umaannamalai umaannamalai marked this pull request as ready for review September 4, 2025 18:20
@umaannamalai umaannamalai requested a review from a team as a code owner September 4, 2025 18:20
lrafeei
lrafeei previously approved these changes Sep 4, 2025
@mergify mergify bot added the tests-failing Tests failing in CI. label Sep 4, 2025
@TimPansino TimPansino enabled auto-merge (squash) September 4, 2025 19:56
@umaannamalai umaannamalai added this to the v10.17.0 milestone Sep 4, 2025
@TimPansino TimPansino merged commit 8683e2c into main Sep 4, 2025
60 checks passed
@TimPansino TimPansino deleted the es-options-bug branch September 4, 2025 20:18
@mergify mergify bot removed the tests-failing Tests failing in CI. label Sep 4, 2025
@Newrelic-Boomi
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants