Skip to content

Conversation

lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Sep 3, 2025

This PR removes the following deprecated settings:

  • transaction_tracer.capture_attributes
  • error_collector.capture_attributes
  • browser_monitoring.capture_attributes
  • analytics_events.capture_attributes
  • analytics_events.enabled
  • error_collector.ignore_errors
  • strip_exception_messages.whitelist
  • ssl (it is required for this to be True, so there is no reason to have an adjustable setting)
  • ignored_params
  • agent_limits.merge_stats_maximum

A separate PR will be filed for capture_params

@mergify mergify bot added the merge-conflicts Merge conflicts detected. label Sep 3, 2025
Copy link

github-actions bot commented Sep 4, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 6 0 0 0.77s
✅ MARKDOWN markdownlint 7 0 0 0 1.28s
✅ MARKDOWN markdown-link-check 7 0 0 29.25s
✅ PYTHON ruff 929 0 0 0 0.9s
✅ PYTHON ruff-format 929 0 0 0 0.35s
✅ YAML prettier 13 0 0 0 1.38s
✅ YAML v8r 13 0 0 8.52s
✅ YAML yamllint 13 0 0 0.64s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@mergify mergify bot added tests-failing Tests failing in CI. and removed merge-conflicts Merge conflicts detected. labels Sep 4, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (develop-11.0.0@fea8317). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             develop-11.0.0    #1482   +/-   ##
=================================================
  Coverage                  ?   81.63%           
=================================================
  Files                     ?      204           
  Lines                     ?    23461           
  Branches                  ?     3710           
=================================================
  Hits                      ?    19152           
  Misses                    ?     3070           
  Partials                  ?     1239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot removed the tests-failing Tests failing in CI. label Sep 5, 2025
@lrafeei lrafeei marked this pull request as ready for review September 5, 2025 20:42
@lrafeei lrafeei requested a review from a team as a code owner September 5, 2025 20:42
@TimPansino TimPansino self-assigned this Sep 5, 2025
@lrafeei lrafeei force-pushed the remove_old_settings branch 2 times, most recently from 84f0c92 to 0f81fa4 Compare September 5, 2025 22:53
@lrafeei lrafeei force-pushed the remove_old_settings branch from 582e00a to 946fa27 Compare September 5, 2025 23:06
@mergify mergify bot added tests-failing Tests failing in CI. and removed tests-failing Tests failing in CI. labels Sep 5, 2025
@TimPansino TimPansino merged commit da753c9 into develop-11.0.0 Sep 9, 2025
105 of 107 checks passed
@TimPansino TimPansino deleted the remove_old_settings branch September 9, 2025 22:57
lrafeei added a commit that referenced this pull request Sep 12, 2025
* Remove transaction_tracer.capture_attributes

* Remove error_collector.capture_attributes

* Remove browser_monitoring.capture_attributes

* Remove analytic_events.capture_attributes

* Remove analytics_events.enabled

* Remove error_collector.ignore_errors

* Remove strip_exception_messages.whitelist

* Remove ssl as a setting

* Remove agent_limits.merge_stats_maximum setting

* Remove ignore_params setting

* ignore_errors removed from test

* Fix megalinter errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants