Skip to content

Conversation

ZetaTom
Copy link
Contributor

@ZetaTom ZetaTom commented Dec 11, 2023

This is one of a series of pull requests which aim to replace all instances of OwnCloudClient with NextcloudClient. The reason for this change is that the newer NextcloudClient uses OkHttp, replacing the outdated Jackrabbit methods.

Specifically, this pull request implements the following:

  • helper classes to ease the transition and refactoring
  • general changes

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 48.85%. Comparing base (26dc847) to head (32a0006).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1271      +/-   ##
============================================
- Coverage     48.94%   48.85%   -0.10%     
  Complexity      996      996              
============================================
  Files           206      208       +2     
  Lines          7835     7850      +15     
  Branches       1019     1019              
============================================
  Hits           3835     3835              
- Misses         3450     3465      +15     
  Partials        550      550              
Files Coverage Δ
...c/main/java/com/nextcloud/operations/HeadMethod.kt 0.00% <0.00%> (ø)
.../main/java/com/nextcloud/common/JSONRequestBody.kt 0.00% <0.00%> (ø)

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

github-actions bot commented Mar 6, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Copy link
Contributor

github-actions bot commented Jun 3, 2024

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

tobiasKaminsky
tobiasKaminsky previously approved these changes Jun 10, 2024
ZetaTom added 3 commits June 10, 2024 12:19
Signed-off-by: ZetaTom <[email protected]>
Signed-off-by: ZetaTom <[email protected]>
@tobiasKaminsky tobiasKaminsky marked this pull request as ready for review June 10, 2024 10:20
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

Signed-off-by: tobiasKaminsky <[email protected]>
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness33
Performance88
Total161161

@tobiasKaminsky tobiasKaminsky merged commit a5b967b into master Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants