Skip to content

Drop NC19 #1813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Drop NC19 #1813

wants to merge 1 commit into from

Conversation

tobiasKaminsky
Copy link
Member

No description provided.

@tobiasKaminsky tobiasKaminsky mentioned this pull request Aug 28, 2025
Open
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total168168

@tobiasKaminsky tobiasKaminsky force-pushed the dropNC19 branch 3 times, most recently from c8d8678 to 904c5e4 Compare August 28, 2025 05:25
@github-actions GitHub Actions
Copy link
Contributor

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total168168

@AndyScherzinger
Copy link
Member

@tobiasKaminsky looking at the original if statements you should be keeping the if branch not the else branch, no?

@nextcloud-android-bot
Copy link
Collaborator

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4445-IT-stable-05-48/debug/

@nextcloud-android-bot
Copy link
Collaborator

master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4446-IT-master-05-49/debug/

@tobiasKaminsky
Copy link
Member Author

@tobiasKaminsky looking at the original if statements you should be keeping the if branch not the else branch, no

you are right!

@tobiasKaminsky
Drop NC19
223023e 
Signed-off-by: tobiasKaminsky <[email protected]>
@tobiasKaminsky
Copy link
Member Author

Fixed

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

SpotBugs

CategoryBaseNew
Bad practice3434
Correctness3434
Dodgy code2626
Internationalization66
Malicious code vulnerability4949
Multithreaded correctness1111
Performance88
Total168168

@nextcloud-android-bot
Copy link
Collaborator

stable-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4466-IT-stable-10-33/debug/

@nextcloud-android-bot
Copy link
Collaborator

master-IT test failed: https://www.kaminsky.me/nc-dev/android-library-integrationTests/4466-IT-master-10-34/debug/

alperozturk96
alperozturk96 requested changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@alperozturk96 alperozturk96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-09-03 at 14 08 51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alperozturk96 alperozturk96 alperozturk96 requested changes

@AndyScherzinger AndyScherzinger Awaiting requested review from AndyScherzinger

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tobiasKaminsky @AndyScherzinger @nextcloud-android-bot @alperozturk96