Skip to content

Conversation

andrey18106
Copy link
Contributor

Related to: nextcloud/server#53121

Implement sensitive Declarative settings encryption for ExApps.

@oleksandr-nc
Copy link
Contributor

In context agent we use appconfig_ex.get_value to read declarative setting values(from fast search by repo sources, @janepie knows for sure).

I guess, that decryption for sensitive values should be added there as well?

@janepie
Copy link
Member

janepie commented May 27, 2025

In context agent we use appconfig_ex.get_value to read declarative setting values(from fast search by repo sources, @janepie knows for sure).

I guess, that decryption for sensitive values should be added there as well?

Yes, also set_value right now

@andrey18106 andrey18106 force-pushed the feat/sensitive-declarative-settings branch from 874e8aa to f22a057 Compare May 27, 2025 17:27
@andrey18106 andrey18106 force-pushed the feat/sensitive-declarative-settings branch from f22a057 to f152c62 Compare May 28, 2025 15:57
@andrey18106 andrey18106 requested a review from kyteinsky May 29, 2025 12:16
Copy link
Collaborator

@kyteinsky kyteinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@andrey18106 andrey18106 force-pushed the feat/sensitive-declarative-settings branch from 54755b1 to 819f104 Compare May 29, 2025 14:07
@andrey18106 andrey18106 enabled auto-merge May 29, 2025 14:08
@andrey18106 andrey18106 merged commit d997d43 into main May 29, 2025
36 checks passed
@andrey18106 andrey18106 deleted the feat/sensitive-declarative-settings branch May 29, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants