Skip to content

Double Click action in View mode #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
newhinton opened this issue May 20, 2022 · 9 comments
Closed

Double Click action in View mode #857

newhinton opened this issue May 20, 2022 · 9 comments
Labels
feature request Requests for complete new features needs discussion Need to clarify if and how we should implement this

Comments

@newhinton
Copy link
Contributor

newhinton commented May 20, 2022

It could be good if a note would switch to editing mode if a user double clicks the view.

I am willing to implement this, this ticket is more a discussion if that is something that would actually make the ui better.

@newhinton newhinton added needs discussion Need to clarify if and how we should implement this feature request Requests for complete new features labels May 20, 2022
@stefan-niedermann
Copy link
Member

I have concerns about the double click action. It is not discoverably nor accessible and maybe there are better solutions like permanently showing the toggle button in combination with a keyboard shortcut.

cc @nextcloud/designers @jancborchardt @nimishavijay

@raimund-schluessler
Copy link
Member

I have concerns about the double click action. It is not discoverably nor accessible and maybe there are better solutions like permanently showing the toggle button in combination with a keyboard shortcut.

cc @nextcloud/designers @jancborchardt @nimishavijay

As long as it's not the only option to switch to edit mode, I see no problem to implement a double click action. Whoever knows it, can use it. Other users just use the normal/known way.
A keyboard shortcut would also be nice, I guess.

@newhinton
Copy link
Contributor Author

I agree with the keyboard shortcut, i will check if there is one and if not, i will add one. Also this will never be the only toggle, there is the button in the trhee-dot menu.

@stefan-niedermann what exactly do youn mean with accessible? Does this 'dubplicate' method need anything?

@korelstar
Copy link
Member

There is already a keyboard shortcut for switching between view mode and edit mode: CTRL + / , see #556 and the discussion on #505

@newhinton
Copy link
Contributor Author

@korelstar I think i have an idea. We could implement a "First Use"-Popup that explains some of the features that we provide. Similar to what nextcloud shows users they log in the first time. As a second step we could also implement an 'in-app'-wiki, similar to how nextcloud/passwords does it. Should i open a new issue for this or is this an unwanted feature?

@korelstar
Copy link
Member

We have already a welcome screen, see #14 (comment) . But I think we should not add every detail there. Instead, an in-app info page with more details could be helpful. We had already some issues regarding this, e.g. #287 and #196. However, the discussion was not very constructive, yet. Maybe you can add some ideas on how to integrate the desired information into the app in the open issue? (The solution should respect how other Nextcloud apps do it, of course)

@korelstar
Copy link
Member

I tried the PR #859, and I agree with @raimund-schluessler.

However, I must say that it's confusing when double clicking on a long note after scrolling down. Currently, the editor mode starts from the top. I think, the use case when double clicking on the text is to start editing at this position. Would it be possible to move (roughly) at the position that I had in view mode?

By the way: when switching from edit mode to view mode, the (rough) position is kept.

@korelstar
Copy link
Member

From nextcloud/notes-android#1519 (comment) :

Double tapping usually triggers on Android a "Select word" action and it also interfers with checkboxes.

"Select a word" is also triggered on web browsers. It is true, that this feature request conflicts with the browser's default behavior. Maybe we should indeed use another shortcut. Maybe the keyboard shortcut CTRL + / is enough?

@korelstar
Copy link
Member

Okay, I finally think we should not introduce this, since double clicking text has another meaning in browsers (see nextcloud/notes-android#1519 (comment)).

@korelstar korelstar closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for complete new features needs discussion Need to clarify if and how we should implement this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants