Skip to content

Add proper fenced code-block formatting #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2018
Merged

Conversation

tristandruyen
Copy link

@tristandruyen tristandruyen commented Oct 2, 2018

Markdown defines tripple back-ticks (```) as delimiter for code blocks, like

this

As i use notes extensively to save shell snippets, hack out readme's and the like, them being in a "normal" non monospaced font is extremely inconvenient...

It looks like my proposed change implements this in a quite minimal manner, and as far as my testing goes, doesn't break anything.

@tristandruyen
Copy link
Author

tristandruyen commented Oct 2, 2018

BTW, While implementing this, I found it quite difficult to get into the simplemd & codemirror stuff, expecially as simplemd seems to be unmaintained since 2 years...
Would a PR to replace the markdown renderer with a more recent, extendable & actively maintained renderer be welcomed?
Are there any big technical hurdles that i should watch out for while implementing this?

If not i would love to contribute a bit more extensively than this 3 line css change^^

@jkaberg
Copy link

jkaberg commented Oct 7, 2018

@tristandruyen #204 😄

@korelstar korelstar merged commit 0c26542 into nextcloud:master Oct 8, 2018
@korelstar korelstar added the design Related to the design or user experience label Oct 8, 2018
@korelstar korelstar added this to the 2.4.3 milestone Oct 8, 2018
@korelstar
Copy link
Member

Thank you very much for this fix!

Some help for enhancing the editor would be greatly appreciated. :-)
As @jkaberg wrote, there is already a discussion on alternatives to SimpleMDE (see #204). Firstly, we should decide for a good library, and then we can implement it in this app. You're welcome on participating in this discussion and, later, do the implementation :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Related to the design or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants