Simple search functionality

[Henni]

fixes #25

looking forward to your reviews
@affanse @korelstar @PhSc @putt1ck @ThomasDaheim @jancborchardt

[korelstar]

Very nice 🎉. Seems to be functional. However, in Firefox, the icon in the search field is displayed in the center (see screenshot) and the text is not selectable per click (however, pressing CTRL+A in the field works). This should be fixed.

A good enhancement would be if search queries with more than one word are split into its parts. I.e.: a search for "wordA wordB" currently finds only notes where wordB comes directly after wordA (with exactly one space in between). It would be better if this search finds all notes containing wordA and wordB at any position.

And one last question: why do you use an in-app search field and not the search from Nextcloud?

[Henni]

@korelstar Am I right when I guess that you are using a Firefox version <= 48? That would explain the problem with the icon positioning (http://caniuse.com/#feat=background-position-x-y). If this is the case, I believe I know how to fix this.
I'm not sure why the text isn't selectable but I'll experiment and try to figure it out.

enhancement: noted - could be fixed in a separate PR, but shouldn't be a huge deal (has been done before http://stackoverflow.com/a/23506051)

I have created an in-app search, because I have heard a rumor that @jancborchardt is unhappy with the global search 😉

[korelstar]

Yes, I'm using the latest ESR version of Firefox and that's 45.5.1.

I've found out, why the text isn't selectable: because the <input> is inside of an <a> tag. Could you remove the <a> tag and use another method to show the search icon?

[Henni]

@korelstar possible but requires duplicating some styles from core. But you are right, that is probably better than wrong markup.

[korelstar]

Maybe you can use a <div> or <span> instead of the <a>. That seems to work (without duplicating the styles).

Edit: okay, there are still some other issues then.

[phsc84]

Thank you for this feature! Works great on Chrome 54.
Regarding the multi word search, I agree with @korelstar. It would be a very nice enhancement, if the search would find all notes containing wordA and wordB at any position.

[Henni]

@korelstar @PhSc I implemented the changes to the search functionality you requested.

[korelstar]

👍 Great work!

[phsc84]

Wonderful! Just tested it on Chrome 54 and Nextcloud 10.0.1. Works like a charm.

• No problem with german umlauts.
• No problem with Markdown formatting codes between two words.

Ready to be merged, from my point of view. 👍