Skip to content

Fix Azure startTask command concatenation #6305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Azure startTask command concatenation #6305

wants to merge 1 commit into from
+2 −2

Conversation

adamrtalbot
Copy link
Collaborator

@adamrtalbot adamrtalbot commented Jul 23, 2025 •
edited
Loading

@netlify Netlify
Copy link

netlify bot commented Jul 23, 2025 •
edited
Loading

✅ Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 03b0501
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/68811411b6e7470008224854
😎 Deploy Preview https://deploy-preview-6305--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@adamrtalbot @claude
Fix Azure Batch startTask concatenation issue (#6300)
03b0501 
Changes semicolon (;) concatenation to logical AND (&&) operator in
startTask command joining to ensure proper command chaining behavior.
This prevents Azure Batch from ignoring commands after the first
semicolon and provides better error handling when azcopy installation
or custom start tasks fail.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
Signed-off-by: adamrtalbot <[email protected]>
@adamrtalbot adamrtalbot force-pushed the fix-azure-starttask-concatenation branch from 6c72493 to 03b0501 Compare July 23, 2025 16:55
@bentsherman bentsherman self-requested a review July 23, 2025 16:55
@bentsherman bentsherman linked an issue Jul 23, 2025 that may be closed by this pull request
nf-azure startTask concatenation fails silently #6300
Open
@adamrtalbot adamrtalbot mentioned this pull request Jul 24, 2025
Open
@pditommaso
Copy link
Member

Not sure to understand what's this is solving (actually tests are broken)

@bentsherman
Copy link
Member

I also don't understand how changing to && fixes the problem reported in the issue

@pditommaso The CI failure is happening across all PRs, looks like a quota issue:

Launching `./test-complexpaths.nf` [maniac_sax] DSL2 - revision: 71e6f6d34a
ERROR ~ Error executing process > 'foo'

Caused by:
  Status code 409, "{
    "odata.metadata":"https://nfbatchtest.westeurope.batch.azure.com/$metadata#Microsoft.Azure.Batch.Protocol.Entities.Container.errors/@Element","code":"ActiveJobAndScheduleQuotaReached","message":{
      "lang":"en-US","value":"Active job and job schedule quota for the account has been reached.\nRequestId:3a4b330c-eafc-4fbc-af7f-a7aa54415c64\nTime:2025-07-23T17:10:56.4462633Z"
    }
  }"

@pditommaso
Copy link
Member

Looking into that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentsherman bentsherman Awaiting requested review from bentsherman

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
executor/azure-batch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nf-azure startTask concatenation fails silently
3 participants
@adamrtalbot @pditommaso @bentsherman