Update library to use typescript #1
Conversation
| ): string | never { | ||
| if ( | ||
| Iterable.isIterable(data) || | ||
| data instanceof Record || |
There was a problem hiding this comment.
There is a new function now that replaces Iterable.isIterable to check if something is Immutable: https://immutable-js.github.io/immutable-js/docs/#/isImmutable -- this will also cover Record.
... unless you're trying to support both Immutable 3 and 4? If so, then personally I'd suggest either something like:
const immutableCheckFn = typeof Immutable.isImmutable === 'function' ? Immutable.isImmutable : Iterable.isIterable;
if (immutableCheckFn(data)) { //...or duck typing:
if (typeof data.toJS === 'function') { //...There was a problem hiding this comment.
@idolize This doesn't update immutablet yet
There was a problem hiding this comment.
Ah, in that case the data instanceof Record check should never trigger since Iterable.isIterable returns true for Records as well.
| decodedData = (RecordType as any).migrate(decodedData); | ||
| } | ||
|
|
||
| return new RecordType(decodedData); |
There was a problem hiding this comment.
Is this guaranteed to be the right way to deserialize (constructor)? It will work with basic key/value pairs that don't require any transform from the server, but perhaps it would be nice to allow a custom decoder as an option, then fall back to constructor. Just a thought - not strictly necessary.
There was a problem hiding this comment.
All of the existing tests pass, this is more of a build/format change. There is already a .migrate method that you can use to decode further (as seen above). Given that this is for next and that the encoding/decoding happens by the same library with no serialization plugins, the decoding should work
I can open an issue if you think it is important
| | OrderedMap<any, any> | ||
| | never { | ||
| const { __iterable: iterableType, data } = iterInfo; | ||
| switch (iterableType) { |
There was a problem hiding this comment.
Nit: a map like { List: listDecoderFn, Set: setDeccoderFn, ... } would be slightly more performant than a switch.
Description
Modernize the library by adding Typescript and prettier, updating function names, creating smaller files, and updating dependencies.
Changes
babelavadependencytypescriptandtsconfigtslinthuskyandlint-staged