Update Immutable to v4 #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 1, 2019 17:41
idolize
reviewed
Mar 5, 2019
| }, | ||
| {} as any, | ||
| ); | ||
| record = new (Record( |
There was a problem hiding this comment.
Would be kinda cool if you cache this Record type somehow based on the keys so there is only one anon. Record type for a given "schema". Idk how much overhead it would be in code / what the perf tradeoffs would be between the two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
immutableto the latest version and adds an option forAnonymousRecordswhen the recordType is not found.Changes
Iterable.isIterableto the newisCollectionmethod for determining if something is an immutable Collection (Map, Set, List, OrderedSet, OrderedMap, Stack)instanceof RecordtoRecord.isRecordfor checking if something is a Recordrecord.toMap()and userecord.toSeq()to iterate through key/value pairsthrowOnMissingRecordTypewhich defaults totrue. Whenfalse, this option will enable the creation of AnonymousRecords that contain all of the data keys found in the initially decodedData.