Skip to content

Add Auxiliary Command Server to Proto #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Jun 11, 2025

Proposed changes

Add AuxiliaryCommandServer to AgentConfig proto

message AgentConfig {
    // Command server settings
    CommandServer command = 1;
    // Metrics server settings
    MetricsServer metrics = 2;
    // File server settings
    FileServer file = 3;
    // A series of key/value pairs to add more data to the NGINX Agent instance
    repeated google.protobuf.Struct labels = 4;
    // A list of features that the NGINX Agent has
    repeated string features = 5;
    // Message buffer size, maximum not acknowledged messages from the subscribe perspective
    string message_buffer_size = 6;
    // Auxiliary Command server settings
    AuxiliaryCommandServer auxiliary_command = 7;
}

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Jun 11, 2025
@aphralG aphralG requested a review from a team as a code owner June 11, 2025 08:47
@github-actions github-actions bot added chore Pull requests for routine tasks documentation Improvements or additions to documentation labels Jun 11, 2025
@dhurley dhurley added the v3.x Issues and Pull Requests related to the major version v3 label Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks documentation Improvements or additions to documentation v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants