Skip to content

Add labels to NAP security logs #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add labels to NAP security logs #1280

wants to merge 1 commit into from

Conversation

spencerugbo
Copy link
Contributor

Proposed changes

This PR aims to label the NAP security logs with additional attributes to make it easier to identify logs from NAP.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@spencerugbo spencerugbo self-assigned this Sep 16, 2025
@spencerugbo spencerugbo requested a review from a team as a code owner September 16, 2025 15:01
@github-actions github-actions bot added the chore Pull requests for routine tasks label Sep 16, 2025
aphralG
aphralG approved these changes Sep 23, 2025
View reviewed changes
Copy link
Contributor

@aphralG aphralG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Unit test just needs to be updated with new label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aphralG aphralG aphralG approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@spencerugbo spencerugbo

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spencerugbo @aphralG