Add fix for inference pool status #4070
Open
+209
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaun-nx
reviewed
Oct 15, 2025
Comment on lines
566
to
567
| fmt.Println("Filtered parents: ", filteredParents) | ||
| fmt.Println("Original parents: ", pool.Status.Parents) |
There was a problem hiding this comment.
Are these prints for debugging or should they stay?
There was a problem hiding this comment.
yea sorry those should be removed
bjee19
force-pushed
the
tests/inference-pool-status
branch
from
d9900c3 to
86b3dcf
Compare
|
@bjee19 This needs to target a different branch. I think you can change the target to the feature branch - this isn't really conformance test specific. Just remove the conformance test enablement and we can update that in the conformance tests branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR that goes into the ongoing
tests/inference-conformancebranch. PassesInferencePoolResolvedRefsConditionconformance test.When setting inference pool statuses, it loops through all the inference pools and checks if there are any nginx gateways that have parentRefs in the statuses. If there are AND the infernece pool is not referenced (not connected to the graph), it will remove that parentRef.