Skip to content

Client span generation for upstream requests #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Client span generation for upstream requests #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
111f621
Configurable span generation for upstream calls (fix: #17)
avahahn Mar 5, 2025
35d342a
Additional testing for upstream spans
avahahn May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/batch_exporter.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ class BatchExporter {
opentelemetry::trace::SpanId parent;
uint64_t start;
uint64_t end;
enum SpanKind{
CLIENT = opentelemetry::proto::trace::v1::Span::SPAN_KIND_CLIENT,
SERVER = opentelemetry::proto::trace::v1::Span::SPAN_KIND_SERVER
} type;
};

class Span {
Expand All @@ -32,7 +36,7 @@ class BatchExporter {
: span(span)
{
span->set_kind(
opentelemetry::proto::trace::v1::Span::SPAN_KIND_SERVER);
(opentelemetry::proto::trace::v1::Span::SpanKind) info.type);

// Short setters, like set_name(), use additional std::string as an
// intermediary at least up to v21.5 of protobuf.
Expand Down
Loading