Skip to content

RFC: Schematics: Extend from @schematics/angular #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MichaelWarneke opened this issue Mar 2, 2018 · 1 comment
Closed

RFC: Schematics: Extend from @schematics/angular #882

MichaelWarneke opened this issue Mar 2, 2018 · 1 comment

Comments

@MichaelWarneke
Copy link
Contributor

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request

What is the current behavior?

Some individual angular cli schematic generators are are listed in the collection.json.
This list has to be kept updated.

Expected behavior:

Extend the ngrx schematics from @schematics/angular and not the individual generators.

Version of affected browser(s),operating system(s), npm, node and ngrx:

@ngrx/schematics 5.1.0

Other information:

The angular devkit has been updated to allow extends.
angular/devkit#34
I created a local branch with required changes and can pull if requested.
Changes:

  • Updated Angular CLI to 1.7.2 (for the new "extends" scheme element)
  • Removed class, component, directive, enum, guard, interface, module, pipe and service from the collection.json
  • Added "extends": ["@schematics/angular"] to the collection.json
  • Implemented a test to check if ngrx schematics runs the extended angular schematics generator ( g class)
MichaelWarneke added a commit to MichaelWarneke/platform that referenced this issue Mar 6, 2018
MichaelWarneke added a commit to MichaelWarneke/platform that referenced this issue Mar 21, 2018
MichaelWarneke added a commit to MichaelWarneke/platform that referenced this issue Mar 21, 2018
@brandonroberts
Copy link
Member

Fixed via 0e17aad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants