Update javascript-styleguide packages to be compatible with eslint v9 #170

gokulprasanth-ni · 2025-09-15T12:09:34Z

Justification

Upgrade to ESLint 9 #155

Resolves #155

Implementation

Remove all the legacy config files and replace them with flat config files.
Update the configurations to use flat config format
Update the dependencies version that support eslint v9.
Update the READMe doc related to this eslint v9 change.

Testing

Packed and applied the updated style guide in our client app - linting passed successfully.

Signed-off-by: gokulprasanth-ni <[email protected]>

packages/eslint-config-javascript/package.json

packages/eslint-config-angular/index.js

packages/eslint-config-angular/tools/print-available-rules.js

packages/eslint-config-playwright/tools/print-available-rules.js

packages/eslint-config-typescript/tools/print-available-rules.js

tests/print-evaluated-rules/index.js

package.json

README.md

change/@ni-eslint-config-angular-2b894e10-2f6e-4ff2-ade2-fae0335c38d8.json

Signed-off-by: gokulprasanth-ni <[email protected]>

change/@ni-eslint-config-angular-2b894e10-2f6e-4ff2-ade2-fae0335c38d8.json

packages/eslint-config-javascript/eslint.config.js

packages/eslint-config-javascript/rules/imports.js

packages/eslint-config-javascript/rules/style.js

packages/eslint-config-playwright/index.js

packages/eslint-config-typescript/index.js

packages/eslint-config-typescript/lib/extensions-requiring-type-checking.js

package.json

change/@ni-eslint-config-angular-2b894e10-2f6e-4ff2-ade2-fae0335c38d8.json

README.md

Signed-off-by: gokulprasanth-ni <[email protected]>

README.md

package.json

packages/eslint-config-javascript/rules/imports.js

Signed-off-by: gokulprasanth-ni <[email protected]>

README.md

Signed-off-by: gokulprasanth-ni <[email protected]>

packages/eslint-config-angular/eslint.config.js

packages/eslint-config-angular/index.js

packages/eslint-config-javascript/eslint.config.js

packages/eslint-config-typescript/eslint.config.js

packages/eslint-config-typescript/index.js

tests/angular/tsconfig.json

tests/playwright/tsconfig.json

tests/print-evaluated-rules/eslint.config.js

jattasNI

No more major concerns from me, just want to see the remaining comment threads resolved. We can talk more about the staging plan at UI Working Group tomorrow if you're available.

Signed-off-by: gokulprasanth-ni <[email protected]>

README.md

Signed-off-by: gokulprasanth-ni <[email protected]>

rajsite · 2025-09-24T18:07:25Z

change/@ni-eslint-config-angular-2b894e10-2f6e-4ff2-ade2-fae0335c38d8.json

@@ -0,0 +1,7 @@
+{


PR is looking very close! Thanks for handling all the feedback so far. I would like to take final review pass but I won't be able to get back to it till later this week (tomorrow afternoon or Friday latest). Let me know if that's a concern

README.md

Signed-off-by: gokulprasanth-ni <[email protected]>

gokulprasanth-ni added 7 commits September 15, 2025 15:11

feat: update packages to eslint v9

7f34462

Signed-off-by: gokulprasanth-ni <[email protected]>

fix: issues

ff13028

Signed-off-by: gokulprasanth-ni <[email protected]>

fix: test issue

96e9cab

Signed-off-by: gokulprasanth-ni <[email protected]>

update angular-eslint version

37d0807

Signed-off-by: gokulprasanth-ni <[email protected]>

update to type module

dfbed78

Signed-off-by: gokulprasanth-ni <[email protected]>

Change files

0168590

update readme doc

382bacb

Signed-off-by: gokulprasanth-ni <[email protected]>

gokulprasanth-ni requested a review from vivinkrishna-ni September 15, 2025 12:12

vivinkrishna-ni approved these changes Sep 16, 2025

View reviewed changes

gokulprasanth-ni added 4 commits September 16, 2025 12:19

update change file email

4e18ae7

Signed-off-by: gokulprasanth-ni <[email protected]>

update as per pr comments

7a2a8c7

Signed-off-by: gokulprasanth-ni <[email protected]>

update angular-eslint version

d830fa3

Signed-off-by: gokulprasanth-ni <[email protected]>

remove no-undef eslint comment

e52cb9d

Signed-off-by: gokulprasanth-ni <[email protected]>

gokulprasanth-ni marked this pull request as ready for review September 16, 2025 10:37

gokulprasanth-ni requested review from jattasNI, rajsite and TrevorKarjanis as code owners September 16, 2025 10:37

fix: import resolver issue

ca9199c

Signed-off-by: gokulprasanth-ni <[email protected]>

jattasNI reviewed Sep 17, 2025

View reviewed changes

change/@ni-eslint-config-angular-2b894e10-2f6e-4ff2-ade2-fae0335c38d8.json Show resolved Hide resolved

jattasNI reviewed Sep 17, 2025

View reviewed changes

rajsite reviewed Sep 17, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

change/@ni-eslint-config-angular-2b894e10-2f6e-4ff2-ade2-fae0335c38d8.json Show resolved Hide resolved

rajsite reviewed Sep 17, 2025

View reviewed changes

README.md Show resolved Hide resolved

address lvl 1 PR comments

df5b22c

Signed-off-by: gokulprasanth-ni <[email protected]>

TrevorKarjanis reviewed Sep 18, 2025

View reviewed changes

gokulprasanth-ni added 6 commits September 18, 2025 19:53

address lvl2 pr comments

56edf11

Signed-off-by: gokulprasanth-ni <[email protected]>

Replace spread with export

c1a09a2

Signed-off-by: gokulprasanth-ni <[email protected]>

handle rules based on comments

a110ff5

Signed-off-by: gokulprasanth-ni <[email protected]>

update print evaluated rules

e278153

Signed-off-by: gokulprasanth-ni <[email protected]>

update print evaluated rules code

7196ed5

Signed-off-by: gokulprasanth-ni <[email protected]>

refactor: update package with named exports

1333caf

Signed-off-by: gokulprasanth-ni <[email protected]>

gokulprasanth-ni added 3 commits September 21, 2025 17:01

enable strict null checks by default

d6a557c

Signed-off-by: gokulprasanth-ni <[email protected]>

add comments to the newly added rules in the project's eslint.config.js

0d197d5

Signed-off-by: gokulprasanth-ni <[email protected]>

Fix: issue

706ae3d

Signed-off-by: gokulprasanth-ni <[email protected]>

gokulprasanth-ni requested review from rajsite, jattasNI and TrevorKarjanis September 21, 2025 11:58

jattasNI added 6 commits September 22, 2025 12:20

Fix 'import/no-extraneous-dependencies': 'off'

8d01013

no-unresolved

f22f19f

Re-add test from typechecking

303f23f

strictNullChecks

90d243e

Fix test failure

f6c6754

README formatting

f50f631

jattasNI reviewed Sep 22, 2025

View reviewed changes

README.md Show resolved Hide resolved

clean up

1de9e26

Signed-off-by: gokulprasanth-ni <[email protected]>

gokulprasanth-ni requested a review from jattasNI September 23, 2025 16:06

TrevorKarjanis reviewed Sep 23, 2025

View reviewed changes

jattasNI reviewed Sep 23, 2025

View reviewed changes

gokulprasanth-ni added 4 commits September 24, 2025 12:25

address PR comments

c549133

Signed-off-by: gokulprasanth-ni <[email protected]>

update moduleResolution to node16

22c786f

Signed-off-by: gokulprasanth-ni <[email protected]>

address lvl2 PR comments

c79ce9c

Signed-off-by: gokulprasanth-ni <[email protected]>

remove unwanted rules

5132f42

Signed-off-by: gokulprasanth-ni <[email protected]>

gokulprasanth-ni requested review from jattasNI and TrevorKarjanis September 24, 2025 09:04

jattasNI approved these changes Sep 24, 2025

View reviewed changes

README.md Show resolved Hide resolved

gokulprasanth-ni added 2 commits September 24, 2025 22:50

update README file

c48ac12

Signed-off-by: gokulprasanth-ni <[email protected]>

update change files

9693626

Signed-off-by: gokulprasanth-ni <[email protected]>

rajsite reviewed Sep 24, 2025

View reviewed changes

TrevorKarjanis approved these changes Sep 25, 2025

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

update eslint configuration in readme

4895a37

Signed-off-by: gokulprasanth-ni <[email protected]>

rajsite self-requested a review September 26, 2025 15:58

Update javascript-styleguide packages to be compatible with eslint v9 #170

Are you sure you want to change the base?

Update javascript-styleguide packages to be compatible with eslint v9 #170

Uh oh!

Conversation

gokulprasanth-ni commented Sep 15, 2025

Justification

Implementation

Testing

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jattasNI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rajsite Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!