Skip to content

add -e to bash to support multiline commands #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

chaporgin
Copy link

Could this help with multiline commands? Not a JS or GH actions expert.

related to: #43 #53

@chaporgin
Copy link
Author

@nick-fields could you please take a look?

@nick-fields
Copy link
Owner

Thanks for the contribution! This seems like an easy enough fix.

Can you add a few tests to the CI/CD workflow? At least two to verify that the traditional multiline and the multiline containing && works. Then negative tests for each where one of the commands in each type of multiline will fail (e.g., call the zzzz executable that doesn't exist).

@chaporgin
Copy link
Author

I added the tests. Somehow I can't see their status:

изображение

So, please @nick-fields , have a look.

@chaporgin
Copy link
Author

chaporgin commented Jun 20, 2022

Tested with act pull_request -j ci --container-architecture linux/amd64 --workflows .github/workflows/ci_cd.yml -v --rm seems to be working.

UPD: it's not working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants