declare list types #907
Merged
declare list types #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
force-pushed
the
list
branch
3 times, most recently
from
92f48dd to
90854a3
Compare
|
@nikic I think the last commit fixed a bug, which phpstan reported because of the more precise typing. I am not sure what todo about the unit tests which fail now. could you give me a hand? |
|
Yeah, that was indeed a bug. I've applied the fix separately in 21a3e8c and cherry-picked this into 4.x as well. Can you please rebase? |
nikic
reviewed
Dec 14, 2022
.github/workflows/main.yml
Outdated
| tools: composer:v2 | ||
| - name: "Install dependencies" | ||
| run: | | ||
| composer global require phpstan/phpstan:1.9.3 |
There was a problem hiding this comment.
Can we install this from tools/composer.json instead?
Co-authored-by: Nikita Popov <[email protected]>
|
should be good to go, thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #905