Another string comparison #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We backport the slightly modified variant from master.
Duplicate metadata can only happen if someone tampers with the phar, so we can and should treat that as error.
* PHP-7.3: Fix #79503: Memory leak on duplicate metadata
Partially reverts 846b647: instead of throwing, this skips uninitialized typed properties when serializing objects. This makes serialize with __sleep() behave the same as serialize() without __sleep(). As in the non-__sleep() case, unserialize(serialize($x)) identity may not be preserved due to replacement of uninitialized/unset properties with default values. Fixing this will require changes to the serialization format. Closes phpGH-5396.
(cherry picked from commit a1a044d on author's explicit request)
* PHP-7.3: Add additional preg_match test case
We have to destroy (un-opened) ZEND_HANDLE_FILENAMEs.
We add support for Activision HSM (`IO_REPARSE_TAG_ACTIVISION_HSM`) and VFS for Git (`IO_REPARSE_TAG_PROJFS`). The latter fixes bug #78784.
* PHP-7.3: Fix #79470: PHP incompatible with 3rd party file system on demand
We add a `get_properties` handler which complements the already existing `has_property` and `read_property`handlers.
* PHP-7.3: Bump version
This reverts commit 6bc8f7e. This causes an assertion failure in PHPUnit.
The timeout is only real-time based on Windows. Make this use a busy wait loop instead. If hard_timeout is broken, this will fail with a run-tests enforced timeout instead.
We have to actually determine the proper `SIZEOF_OFF_T`. Interestingly, it is `4` on Windows x64. We also have to prevent the redefinition in pg_config.h. The clean solution would likely be to not include pg_config.h at all, but that's out of scope for BC reasons for now.
* 'PHP-7.4' of git.php.net:/php-src: Fix #79532: sizeof off_t can be wrong Make 045.phpt busy wait Revert "Fix #79065: DOM classes do not expose properties to Reflection" Bump version Fix #79065: DOM classes do not expose properties to Reflection Fix #79470: PHP incompatible with 3rd party file system on demand
On Windows, reusing/sharing of OPcache instances with different configuration is not necessarily supported, so we have to make that it does not happen for the clean scripts, by using `$orig_ini_settings` instead of `$clean_params`.
Let's go from 32 to 16 parallel jobs. We can reduce this further if necessary. Closes phpGH-5426.
Revert "Fix #61597: SXE properties may lack attributes and content" This reverts commit 7c081db.
* PHP-7.3: Fix #79528: Different object of the same xml between 7.4.5 and 7.4.4
This function is lacking any tests so far.
* PHP-7.3: Add basic sapi_windows_cp_conv() test
Disabling postgresql entirely for now, because I can't figure out how to fix it. Something broke big time with i386 packages on Azure pipelines.
We did not allocate a cache slot for FETCH_CLASS. This is already fixed on newer PHP versions.
* PHP-7.3: Fixed bug #79535
…ule init corrupts memory)" This reverts commit a297c09.
This reverts commit ccd41e0. This causes a large performance regression when notices are thrown and large arrays are in scope, see bug #79794.
Move the emission of the undefined variable notice before the array separation.
Some of the code paths leading to this do not fetch op data. Hopefully this fixes the release build failure.
Both tests used the same folder, which could clash in case the tests are run simultaneously.
* PHP-7.3: Fix some memory bugs in ldap.c
We mark symlink_link_linkinfo_is_link_error2.phpt as XFAIL on Windows
ZTS. Several Windows API file system functions ignore trailing spaces
in absolute filenames after the final directory separator, which causes
`link(' ', $link)` to actually call `CreateHardLink()` which then
fails, because linking folders is not supported. However, with NTS
builds (as well as on other systems), the $target is found to not
exist, so the function fails without actually attempting to create the
link. This needs further investigation.
These tests fail on Windows for different reasons, but not because symlinks, links, or lstat() would not be supported on Windows generally.
Use *_IND macros in a few places in string.c.
* PHP-7.3: Fixed bug #79817
HashTable was reallocated (zend_hash_packed_grow) during php_var_dump, so we should call GC_ADDREF to make SEPARATE_ARRAY work. Closes phpGH-5837.
* PHP-7.3: Fixed bug #79821
This also fixes memory error in debug_zval_dump and var_export.
* PHP-7.3: Fixed bug #79830 introduced by fixing bug #79821
It introduced by fixing bug #79830
* PHP-7.3: Fixed BC break of php_debug_zval_dump
`st_dev` deliberately overflows on such systems, cf. <http://svn.php.net/viewvc?view=revision&revision=350100>.
Closes phpGH-5853.
* PHP-7.3: Fixed bug #79849
* upstream/PHP-7.4: Fix test for x86 Windows
Similar to what is done for ReflectionType itself, copy the type name stored inside ReflectionProperty. Also make sure the type field is always initialized for dynamic properties. This is a non-issue in PHP 8, because we store a pointer to the property_info there, rather than a copy.
While the comparison result changes, the equality comparison is not going to care about it in the end.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.