Skip to content

Fix: Test failed when creating a new project #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hoangmirs opened this issue Apr 4, 2022 · 1 comment · Fixed by #71
Closed

Fix: Test failed when creating a new project #63

hoangmirs opened this issue Apr 4, 2022 · 1 comment · Fixed by #71
Assignees
@malparty
Labels
type : bug
Milestone
2.2.0

Comments

@hoangmirs
Copy link
Contributor

hoangmirs commented Apr 4, 2022 •
edited
Loading

Issue

Expected

npm run test should be run properly

Steps to reproduce

  1. Create a new project
  2. Run npm run test and observe the result
@malparty
Copy link
Member

malparty commented Apr 5, 2022 •
edited
Loading

Issue found: the .tool-versions file should be copied under the template folder. I'll handle that today.

@malparty malparty self-assigned this Apr 5, 2022
This was referenced Apr 5, 2022
Merged
Merged
@carryall carryall added this to the 2.2.0 milestone Apr 6, 2022
carryall added a commit that referenced this issue Apr 6, 2022
@carryall
Merge pull request #71 from nimblehq/bug/gh63-fix-missing-tool-versions
4700265 
[#63] Add .tool-versions file in the template folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malparty malparty

Labels
type : bug
Projects
None yet
Milestone
2.2.0
Development

Successfully merging a pull request may close this issue.

[#63] Add .tool-versions file in the template folder nimblehq/react-templates
3 participants
@carryall @hoangmirs @malparty