ENH: Allow save-time passing of on-disk dtype to save functions #1083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A common idiom is to use a higher-precision internal data type before saving to a lower-precision on-disk data type. The
set_data_dtype()
method is a little clunky. This permits the following:Only implemented for Analyze-like images here. Related to discussion in #1046, but does not (currently) warn for int64 data being saved without a dtype argument.