Skip to content

MNT: 5.0.0.dev0 #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Dec 16, 2022
Merged

MNT: 5.0.0.dev0 #1141

merged 17 commits into from
Dec 16, 2022

Conversation

effigies
Copy link
Member

@effigies effigies commented Oct 3, 2022

To finish #1089, we will be releasing 5.0 in the next couple months. (If we keep the original 6 month schedule, December. If we push ahead, it could be in October.)

This PR bumps the dev version and removes API components that were deprecated in the 2.x series and have been throwing errors in 4.0.

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 91.84% // Head: 92.28% // Increases project coverage by +0.43% 🎉

Coverage data is based on head (4d4fc99) compared to base (34fb3ec).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1141      +/-   ##
==========================================
+ Coverage   91.84%   92.28%   +0.43%     
==========================================
  Files         101       98       -3     
  Lines       12447    12236     -211     
  Branches     2575     2515      -60     
==========================================
- Hits        11432    11292     -140     
+ Misses        688      619      -69     
+ Partials      327      325       -2     
Impacted Files Coverage Δ
nibabel/conftest.py 100.00% <ø> (ø)
nibabel/dataobj_images.py 98.24% <ø> (+1.52%) ⬆️
nibabel/ecat.py 88.18% <ø> (+0.11%) ⬆️
nibabel/filebasedimages.py 92.51% <ø> (+0.46%) ⬆️
nibabel/freesurfer/mghformat.py 95.06% <ø> (+2.12%) ⬆️
nibabel/gifti/__init__.py 100.00% <ø> (ø)
nibabel/gifti/parse_gifti_fast.py 85.53% <ø> (+0.63%) ⬆️
nibabel/imageclasses.py 100.00% <ø> (+6.06%) ⬆️
nibabel/loadsave.py 93.04% <ø> (+8.54%) ⬆️
nibabel/nicom/dicomwrappers.py 90.82% <ø> (+0.15%) ⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies effigies merged commit e5b67f1 into nipy:master Dec 16, 2022
@effigies effigies added this to the 5.0.0 milestone Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant