BF: Fix for 'split' (concatenated?) multiframe DICOM #1328
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't just use number of frame indices to determine shape of data, as the actual frames could still be split into different files. Also can't assume a multiframe file is more than a single slice.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1328 +/- ##
==========================================
- Coverage 92.20% 92.19% -0.01%
==========================================
Files 98 98
Lines 12400 12400
Branches 2557 2559 +2
==========================================
- Hits 11433 11432 -1
Misses 644 644
- Partials 323 324 +1 ☔ View full report in Codecov by Sentry. |
|
It seems like the "TestMultiFrameWrapper.test_data_trace" test assumes we will keep any extra-spatial (after 3rd dimension) singular dimensions. I can keep that behavior if desired but it seems counter intuitive. |
|
Closing in favor on #1340 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't just use number of frame indices to determine shape of data, as the actual frames could still be split into different files. Also can't assume a multiframe file is more than a single slice.
I am checking with colleagues if we have some phantom data I can use to create a test case.