MAINT: update numpy dependency; add Python 3.6 #506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-brett
force-pushed
the
extend-testing
branch
2 times, most recently
from
0fe9a8a to
8efab30
Compare
Current coverage is 94.02% (diff: 100%)@@ master #506 diff @@
==========================================
Files 166 166
Lines 21992 21992
Methods 0 0
Messages 0 0
Branches 2343 2343
==========================================
Hits 20679 20679
Misses 878 878
Partials 435 435
|
|
I think this one is a fairly straightforward win - any takers for a quick review? |
grlee77
reviewed
Jan 25, 2017
| @@ -23,10 +23,12 @@ env: | |||
| - DEPENDS="numpy scipy matplotlib h5py pillow" | |||
| - PYDICOM=1 | |||
| - INSTALL_TYPE="setup" | |||
| - EXTRA_WHEELS="https://5cf40426d9f06eb7461d-6fe47d9331aba7cd62fc36c7196769e4.ssl.cf2.rackcdn.com" | |||
| - PIP_FLAGS="--find-links=$EXTRA_WHEELS" | |||
There was a problem hiding this comment.
Is this PIP_FLAGS always included by pip in all cases then? I was unfamiliar with that environment variable and don't see it mentioned in the manual? I would have guessed it wanted PIP_FIND_LINKS.
There was a problem hiding this comment.
Oops - sorry - that should be EXTRA_PIP_FLAGS, used explicitly below. I've changed it...
|
LGTM. the comment above is mainly a question for my own education |
This will also trigger tests against the latest wheels.
Integer indices, array returned instead of memmap.
matthew-brett
force-pushed
the
extend-testing
branch
from
3ef6191 to
98dcd77
Compare
|
Thanks for the review - merging as I think this stuff is uncontroversial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will also trigger tests against the latest wheels.