Skip to content

Conversation

effigies
Copy link
Member

Orthoview displays in neurological convention (left on the left, etc.) but places labels as if the display is radiological. This fix simply changes the labels.

If radiological convention is desired, we may want to consider adding an option, but that seems like it would make sense with a more significant refactor to simplify (or at least clarify) the visualization code.

Closes #559.

@codecov-io
Copy link

codecov-io commented Oct 14, 2017

Codecov Report

Merging #564 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #564   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files         177      177           
  Lines       24691    24691           
  Branches     2638     2638           
=======================================
  Hits        23290    23290           
  Misses        925      925           
  Partials      476      476
Impacted Files Coverage Δ
nibabel/viewers.py 96.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7eee37...ee7d536. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.254% when pulling ee7d536 on effigies:fix/orthoview_lr_labels into b7eee37 on nipy:master.

@effigies
Copy link
Member Author

Think this one should be pretty uncontroversial. Will merge tomorrow AM (EDT) unless there's an objection.

@effigies effigies merged commit b2c0f81 into nipy:master Oct 18, 2017
@effigies effigies deleted the fix/orthoview_lr_labels branch November 23, 2017 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flip dimensions in OrthoSlicer3D
3 participants