MRG: fix lower-case TRK codes, add error message #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Kesshi Jordan pointed out, TRK files can have lower-case axis codes, and this causes unexpected output from axcodes2ornt. Extend axcodes2ornt to a) Check whether the axis codes do in fact correspond to the labels. b) Check for duplicate labels.
Codecov Report
@@ Coverage Diff @@
## master #600 +/- ##
==========================================
+ Coverage 93.4% 94.47% +1.06%
==========================================
Files 189 177 -12
Lines 25820 24962 -858
Branches 2752 2661 -91
==========================================
- Hits 24118 23582 -536
+ Misses 1205 908 -297
+ Partials 497 472 -25
Continue to review full report at Codecov.
|
|
That looks good, @matthew-brett . Thanks! |
|
@effigies - any thoughts on this one? |
|
LGTM |
|
Thanks @kesshijordan @effigies . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #590 - Kesshi's initial fix and test, plus some better error
checking in axcodes2ornt.