BF(workaround): skip test_diff if hypothesis is not importable #675
Conversation
Apparently hypothesis is quite a tricky beast. It might either fail to install on elderly systems from source tarball, or even if it is installable, apparently might rely on some coverage API which is present only in more recent versions and thus fail upon import. All those are of relevance for older systems and only for testing.
|
worse comes to worse, I could actually just keep this patch in the debian pkg so it would help to avoid some of those on older systems... may be that would actually be better? |
|
Or given all the appveyor difficulties we should just rip appveyor out for now and limit ourselves to just some set of cases? |
Codecov Report
@@ Coverage Diff @@
## master #675 +/- ##
=======================================
Coverage 88.86% 88.86%
=======================================
Files 93 93
Lines 11378 11378
Branches 1869 1869
=======================================
Hits 10111 10111
Misses 930 930
Partials 337 337Continue to review full report at Codecov.
|
| import hypothesis.strategies as st | ||
| except Exception as exc: | ||
| from nose import SkipTest | ||
| raise SkipTest("Failed to import hypothesis or its components: %s" % exc) |
There was a problem hiding this comment.
To avoid necessarily skipping the entire file, what about making this except statement:
except ImportError:
class st(object):
@classmethod
def data(klass):
return None
def given(obj):
def decorator(func):
def null_test():
return None
return decoratorMaybe raise a warning, as well.
|
#678 prunes use of hypothesis altogether |
Apparently hypothesis is quite a tricky beast. It might either fail to install
on elderly systems from source tarball, or even if it is installable, apparently
might rely on some coverage API which is present only in more recent versions
and thus fail upon import.
All those are of relevance for older systems and only for testing.
I know that e.g. #661 would add tests in the
test_diff.pywhich would not even need hypothesis, but I do not see easy way to make it work since hypothesis's given is used as a decorator.