ENH: Add bytestring serialization to CIFTI-2 #938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #938 +/- ##
=======================================
Coverage 91.84% 91.84%
=======================================
Files 97 97
Lines 12423 12427 +4
Branches 2190 2191 +1
=======================================
+ Hits 11410 11414 +4
Misses 678 678
Partials 335 335
Continue to review full report at Codecov.
|
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CIFTI-2 is serializable, so might as well add it in. This required making
Cifti2Headercomparable, and fixing a small bug where each attempt to save or serialize a CIFTI-2 image adds aCifti2Extensionwithout clearing out old ones.@mgxd Would you mind reviewing this one?