Skip to content

FIX: Constrain environment dictionary to bytes in Windows #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2017

Conversation

effigies
Copy link
Member

Fixes #2068.

Changes proposed in this pull request

  • Constrain environment dictionary to bytes in Windows

This filter is run just before the Popen call, which has the advantage that it will be very difficult for a unicode entry to slip through, but the disadvantage that any work that it does will be done many times. Still, it should be a cheap operation.

@codecov-io
Copy link

codecov-io commented Jun 21, 2017

Codecov Report

Merging #2085 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2085      +/-   ##
==========================================
- Coverage   72.13%   72.13%   -0.01%     
==========================================
  Files        1138     1138              
  Lines       57268    57280      +12     
  Branches     8206     8210       +4     
==========================================
+ Hits        41313    41319       +6     
- Misses      14663    14669       +6     
  Partials     1292     1292
Flag Coverage Δ
#smoketests 72.13% <33.33%> (-0.01%) ⬇️
#unittests 69.74% <25%> (-0.01%) ⬇️
Impacted Files Coverage Δ
nipype/interfaces/base.py 83.43% <33.33%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5040260...da57c93. Read the comment docs.

@satra satra merged commit 94a11f0 into nipy:master Jun 23, 2017
@effigies effigies deleted the fix/windows_env branch October 5, 2017 20:32
@satra satra added this to the 0.14.0 milestone Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants