Skip to content

[ENH] Minor improvements to PR template #2636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 19, 2018
Merged

[ENH] Minor improvements to PR template #2636

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17cf00a
[ENH] Minor improvements to PR template
oesteban Jul 13, 2018
f1859d4
Update PULL_REQUEST_TEMPLATE.md
oesteban Jul 13, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,24 @@
Pull-request guidelines (Remove this section after reading):
<!--
Pull-request guidelines
-----------------------
1. If you would like to list yourself as a Nipype contributor and your name is not mentioned please modify .zenodo.json file.
2. By submitting this request you acknowledge that your contributions are available under the Apache 2 license.
3. Use a descriptive prefix for your PR: ENH (enhancement), FIX, TST, DOC, STY, REF (refactor), WIP (Work in progress)
4. The person who accepts/merges your PR will include an update to the CHANGES file: prefix: description (URL of pull request)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove 4) as this is now scripted

5. Run `make check-before-commit` before submitting the PR.
----- REMOVE TILL HERE -----
-->
## Summary
<!-- Please reference any related issue and use fixes/close to automatically
close them, if pertinent -->

Fixes # .

Changes proposed in this pull request
-
-
## List of changes proposed in this PR (pull-request)
<!-- We suggest using bullets (indicated by * or -) and filled checkboxes [x] here -->

## Acknowledgment

- [ ] \(Mandatory\) I acknowledge that this contribution will be available under the Apache 2 license.