Skip to content

Add support for ppoll() #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Susurrus opened this issue Feb 16, 2017 · 5 comments
Closed

Add support for ppoll() #517

Susurrus opened this issue Feb 16, 2017 · 5 comments

Comments

@Susurrus
Copy link
Contributor

poll() is already included, but ppoll() would be nice too. Since there's a PR for pselect() I figured ppoll() would be suitable for inclusion as well.

@kamalmarhubi
Copy link
Member

@Susurrus it'd certainly be welcome! Any chance you'd be interested in adding it? I could walk you through it if so.

@Susurrus
Copy link
Contributor Author

Yeah, I'd like to get this added, but it looks like I'll first need to add ppoll() to libc.

Also, what should the function definition be? Given the consensus in #516 I would like to do:
fn ppoll(fds: &mut [PollFd], timeout: Duration) -> Result<libc::c_int>. Does that work?

@Susurrus
Copy link
Contributor Author

I can file an addition PR for #516 that will synchronize everything on using Duration, but I'm assuming the API discrepency will be acceptable in the short term?

@Susurrus
Copy link
Contributor Author

Just filed a PR for this for libc, but it'll probably take a couple of revisions nailing down what platforms actually support this (rust-lang/libc#537).

@Susurrus
Copy link
Contributor Author

Closed by 5d4967e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants