Fix test_vsock failure on VMADDR_CID_LOCAL testing and re-enable it #1407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from Linux 5.6, VMADDR_CID_LOCAL is supported to do local communication (loopback device). Before Linux 5.6 it was called VMADDR_CID_RESERVED and was not supported, so we could expect an EADDRNOTAVAIL, but now this address is supported and handled by the 'vsock_loopback' kernel module loaded automatically if no other vsock transports are loaded. Issue nix-rust#1310 Issue nix-rust#1403 Signed-off-by: Stefano Garzarella <[email protected]>
This reverts commit c0783e7. Now the test should work correctly, so we can re-enable it. Signed-off-by: Stefano Garzarella <[email protected]>
qwandor-google
approved these changes
Mar 22, 2021
asomers
approved these changes
Mar 23, 2021
bors bot
added a commit
that referenced
this pull request
Mar 23, 2021
1407: Fix test_vsock failure on VMADDR_CID_LOCAL testing and re-enable it r=asomers a=stefano-garzarella Starting from Linux 5.6, `VMADDR_CID_LOCAL` is supported to do local communication (loopback device). Before Linux 5.6 it was called `VMADDR_CID_RESERVED` and was not supported, so we could expect an `EADDRNOTAVAIL`, but now this address is supported and handled by the 'vsock_loopback' kernel module loaded automatically if no other vsock transports are loaded. Issue #1310 Issue #1403 Signed-off-by: Stefano Garzarella <[email protected]> Co-authored-by: Stefano Garzarella <[email protected]>
|
Build failed: |
|
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from Linux 5.6,
VMADDR_CID_LOCALis supported to do local communication (loopback device).Before Linux 5.6 it was called
VMADDR_CID_RESERVEDand was not supported, so we could expect anEADDRNOTAVAIL, but now this address is supported and handled by the 'vsock_loopback' kernel module loaded automatically if no other vsock transports are loaded.Issue #1310
Issue #1403
Signed-off-by: Stefano Garzarella [email protected]