switch nmcclain/asn1-ber to go-asn1-ber/asn1-ber. #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This newer package has ben updated with tests, and looks to actually be supported. It is also is a forked version of nmcclain/asn1-ber, so supports the same API.
DBarney
changed the title
|
Now all tests pass. SSL was failing to work as the certs were untrusted. and The flakiness I was seeing was because starting and stopping the server quickly in the tests could cause one to be started while the other still hadn't shutoff yet. I added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This newer package has ben updated with tests, and looks to actually be supported.
It is also is a forked version of nmcclain/asn1-ber, so supports the same API.
TestBindSSL is flaky, it doesn’t seem to actually bind correctly for some reason. Other then that all tests seem to pass.