-
Notifications
You must be signed in to change notification settings - Fork 711
About interface #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Another suggestion: the result points are aranged in a max heap, while what people interested in is the nearest points. I would suggest using another comparator that would return a min heap. Lines 928 to 937 in 44f20f0
|
@uestc-lfs Thanks for the suggestions! Seems reasonable. |
Would you like some pull requests for these suggestions? |
@uestc-lfs |
I'm integrating hnswlib into my own code, I have the following suggestions:
addPoint
should beconst void *
.hnswlib/hnswlib/hnswalg.h
Line 773 in 44f20f0
searchKnn
shuld first check if the "container" is empty, in wich case a search may result in a core dump.hnswlib/hnswlib/hnswalg.h
Line 486 in 44f20f0
The text was updated successfully, but these errors were encountered: