GCC sign_compare and reorder warning flags patches #233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurymalkov
reviewed
Jul 15, 2020
| @@ -26,7 +26,7 @@ namespace hnswlib { | |||
| } | |||
|
|
|||
| HierarchicalNSW(SpaceInterface<dist_t> *s, size_t max_elements, size_t M = 16, size_t ef_construction = 200, size_t random_seed = 100) : | |||
| link_list_locks_(max_elements), element_levels_(max_elements), link_list_update_locks_(max_update_element_locks) { | |||
| link_list_locks_(max_elements), link_list_update_locks_(max_update_element_locks), element_levels_(max_elements) { | |||
There was a problem hiding this comment.
Hm. I wonder, why the order matters here?
There was a problem hiding this comment.
I the order only really matters pragmatically, for when a client (such as myself) needs to include hnswlib in a project that builds with the -Wall -Werror compiler flags by policy, in which case this won't compile. I doubt there's actually any problem in this particular case, and the warning is just a false positive, but https://stackoverflow.com/questions/1828037/whats-the-point-of-g-wreorder explains the justification for this GCC warning flag in general.
There was a problem hiding this comment.
I see. Thanks! Didn't know about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to compile with -Werror=sign_compare and -Werror=reorder, a few small int -> size_t replacements and constructor initialization list.