Feature/pep #284
Merged
Feature/pep #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marekhanus
force-pushed
the
feature/pep
branch
from
eb1dcc5 to
20555b7
Compare
dyashuni
reviewed
Feb 4, 2021
Comment on lines
+23
to
+29
| # Initiating index | ||
| # max_elements - the maximum number of elements, should be known beforehand | ||
| # (probably will be made optional in the future) | ||
| # | ||
| # ef_construction - controls index search speed/build speed tradeoff | ||
| # M - is tightly connected with internal dimensionality of the data | ||
| # strongly affects the memory consumption |
There was a problem hiding this comment.
The same comments are in bindings_test_labels.py, bindings_test_getdata.py, bindings_test.py. Could please correct these files too ?
There was a problem hiding this comment.
Oh sorry, I missed it. Fixed in 0e3845f.
marekhanus
force-pushed
the
feature/pep
branch
from
9683a4a to
0e3845f
Compare
dyashuni
approved these changes
Feb 9, 2021
|
Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo fixes, PEP 8