Skip to content

fix: remove gently hijack and tests #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@ language: node_js
node_js:
- 10
- 12
- 13
2 changes: 0 additions & 2 deletions lib/file.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
if (global.GENTLY) require = GENTLY.hijack(require);

var util = require('util'),
fs = require('fs'),
EventEmitter = require('events').EventEmitter,
Expand Down
2 changes: 0 additions & 2 deletions lib/incoming_form.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
if (global.GENTLY) require = GENTLY.hijack(require);

var crypto = require('crypto');
var fs = require('fs');
var util = require('util'),
Expand Down
2 changes: 0 additions & 2 deletions lib/json_parser.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
if (global.GENTLY) require = GENTLY.hijack(require);

function JSONParser(parent) {
this.parent = parent;
this.chunks = [];
Expand Down
2 changes: 0 additions & 2 deletions lib/querystring_parser.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
if (global.GENTLY) require = GENTLY.hijack(require);

// This is a buffering parser, not quite as nice as the multipart one.
// If I find time I'll rewrite this to be fully streaming as well
var querystring = require('querystring');
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
"license": "MIT",
"version": "1.2.1",
"devDependencies": {
"gently": "^0.8.0",
"findit": "^0.1.2",
"hashish": "^0.0.4",
"urun": "^0.0.6",
Expand Down
Binary file added test-legacy/.DS_Store
Binary file not shown.
3 changes: 3 additions & 0 deletions test-legacy/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@

These tests were deleted due to failures when removing the gently lib.
previously in `test/legacy`
8 changes: 0 additions & 8 deletions test/legacy/common.js → test-legacy/common.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,8 @@
var path = require('path'),
fs = require('fs');

try {
global.Gently = require('gently');
} catch (e) {
throw new Error('this test suite requires node-gently');
}

exports.lib = path.join(__dirname, '../../lib');

global.GENTLY = new Gently();

global.assert = require('assert');
global.TEST_PORT = 13532;
global.TEST_FIXTURES = path.join(__dirname, '../fixture');
Expand Down
File renamed without changes.