Remove statuses package, use built in http.STATUS_CODES #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HappyZombies
changed the title
|
FYI -- this will make #9 invalid and be closed once this is approved. |
|
@HappyZombies you can take a second look and merge if you like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply removes the statuses dependency from the module and uses the built in
The http.STATUS_CODES object has been a part of Node since the beginning, since v0.1.22 actually, so this should not affect backwards combability.
The
statusespackage was only being used in the OAuthError class (lib/errors/oauth-error.js). The OAuthError class takes two properties, first being either a message or an Error object instance, while the second property can support taking a "code" along with a few other properties (read more in the docs about this class).Anyways, if the second property did not contain anything, it will default to the value of
{code: 500}, and then it will access the http.STATUS_CODES to retrieve the message for this error to then attach it to the custom OAuthError object.This addresses and resolves #21