Skip to content

Mark as a pull request for a corresponding issue #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
twolfson opened this issue Nov 7, 2014 · 12 comments
Closed

Mark as a pull request for a corresponding issue #4

twolfson opened this issue Nov 7, 2014 · 12 comments

Comments

@twolfson
Copy link

twolfson commented Nov 7, 2014

I triaged nodejs/node-v0.x-archive#8602 under the pretense of all the answers being about nodejs/node-v0.x-archive#7676. Should we make a way to link PR's to issues to prevent double triaging?

@mcwhittemore
Copy link

Just tried to triage joyent/node#8212 but most of the questions are very bug/request orientated and 8212 is a PR to solve joyent/node#8210. Should PRs be removed fully? Maybe they get a different question flow?

@twolfson
Copy link
Author

I think they should be left in but need an away to combine them. Sometimes people open PRs without opening an issue first. I don't think marking it as a duplicate applies since usually you close the duplicate and with a PR, they depend on one another.

@mcwhittemore
Copy link

Yea. I think if its a PR the first question should be "does this relate to another issue" and if it does it should ask questions about if it is a good answer otherwise it should be treated like an issue.

@srl295
Copy link

srl295 commented Nov 10, 2014

I triaged nodejs/node-v0.x-archive#8602 under the pretense of all the answers being about nodejs/node-v0.x-archive#7676. Should we make a way to link PR's to issues to prevent double triaging?

What does this mean?

@twolfson
Copy link
Author

I am guessing you seeing a link from #8602/#7676 and are confused what this repo is about. I will try to clarify with background on nodebugme. nodebugme is a project/site attempting to triage all open issues on joyent/node.

https://nodebug.me/

I was assigned to triage #8602, which is a PR, and noticed that it is resolving to #7676. I decided to answer the questions for #8602 as if they were for #7676 because #8602 was lacking of a thread. I decided to open this issue to determine how we should handle the situation in the future.

@srl295
Copy link

srl295 commented Nov 11, 2014

@twolfson yeah.. where does the triaging go?
Anyways- nodejs/node-v0.x-archive#8602 fixes nodejs/node-v0.x-archive#8521 which was introduced by the already-pulled nodejs/node-v0.x-archive#7719. nodejs/node-v0.x-archive#7676 is the "big picture" which depends on nodejs/node-v0.x-archive#7719 being done, but has some more work. There's also nodejs/node-v0.x-archive#8681 which fixes another issue with nodejs/node-v0.x-archive#7676 .. does that help?

@twolfson
Copy link
Author

I don't know the mechanism where triage results are added to the issues themselves. Maybe open another issue in this repo to get that clarified?

Regarding the issues themselves, yes it helps this discussion. Issues are a tangled web of dependencies o_o

@srl295
Copy link

srl295 commented Nov 11, 2014

@twolfson https://nodebug.me/ says a core contributor looks at it and something about sarcasm tags.

Anyways, I think the original approach makes some sense. nodejs/node-v0.x-archive#8602 just supports nodejs/node-v0.x-archive#7676

@chrisdickinson
Copy link
Contributor

@srl295 sorry about that! I'm the core contributor in question, and I've been working on exposing the results through a REST API for the rest of the contributors / the general public.

I'm pretty convinced that we should remove PRs from the triage queue. They necessitate a totally different set of questions. Somewhat embarrassingly, I was unaware they were showing up in the queue!

@twolfson
Copy link
Author

Works for me. I guess we will leave the issue open until that is implemented in nodebugme/site.

@chrisdickinson
Copy link
Contributor

It should be fixed now.

@twolfson
Copy link
Author

Yay =3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants