-
Notifications
You must be signed in to change notification settings - Fork 0
Mark as a pull request for a corresponding issue #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Just tried to triage joyent/node#8212 but most of the questions are very bug/request orientated and 8212 is a PR to solve joyent/node#8210. Should PRs be removed fully? Maybe they get a different question flow? |
I think they should be left in but need an away to combine them. Sometimes people open PRs without opening an issue first. I don't think marking it as a duplicate applies since usually you close the duplicate and with a PR, they depend on one another. |
Yea. I think if its a PR the first question should be "does this relate to another issue" and if it does it should ask questions about if it is a good answer otherwise it should be treated like an issue. |
What does this mean? |
I am guessing you seeing a link from I was assigned to triage |
@twolfson yeah.. where does the triaging go? |
I don't know the mechanism where triage results are added to the issues themselves. Maybe open another issue in this repo to get that clarified? Regarding the issues themselves, yes it helps this discussion. Issues are a tangled web of dependencies o_o |
@twolfson https://nodebug.me/ says a core contributor looks at it and something about sarcasm tags. Anyways, I think the original approach makes some sense. nodejs/node-v0.x-archive#8602 just supports nodejs/node-v0.x-archive#7676 |
@srl295 sorry about that! I'm the core contributor in question, and I've been working on exposing the results through a REST API for the rest of the contributors / the general public. I'm pretty convinced that we should remove PRs from the triage queue. They necessitate a totally different set of questions. Somewhat embarrassingly, I was unaware they were showing up in the queue! |
Works for me. I guess we will leave the issue open until that is implemented in |
It should be fixed now. |
Yay =3 |
I triaged nodejs/node-v0.x-archive#8602 under the pretense of all the answers being about nodejs/node-v0.x-archive#7676. Should we make a way to link PR's to issues to prevent double triaging?
The text was updated successfully, but these errors were encountered: