Skip to content

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Sep 8, 2022

Signed-off-by: Michael Dawson [email protected]

mhdawson added a commit to mhdawson/io.js that referenced this pull request Sep 8, 2022
- updated based on decision to use node: prefix in
  nodejs/TSC#1206
- updated based on agreement in TSC meeting
  on adding /promises to existing modules as per
  minutes - nodejs/TSC#1281

Signed-off-by: Michael Dawson <[email protected]>
@mhdawson
Copy link
Member Author

mhdawson commented Sep 8, 2022

PR to add updated guidance on adding new modules based on earlier vote and discussion in the TSC meeting yesterday - nodejs/node#44576

Co-authored-by: Geoffrey Booth <[email protected]>
@Trott Trott merged commit ae738f1 into nodejs:main Sep 13, 2022
mhdawson added a commit to nodejs/node that referenced this pull request Sep 23, 2022
- updated based on decision to use node: prefix in
  nodejs/TSC#1206
- updated based on agreement in TSC meeting
  on adding /promises to existing modules as per
  minutes - nodejs/TSC#1281

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #44576
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
RafaelGSS pushed a commit to nodejs/node that referenced this pull request Sep 26, 2022
- updated based on decision to use node: prefix in
  nodejs/TSC#1206
- updated based on agreement in TSC meeting
  on adding /promises to existing modules as per
  minutes - nodejs/TSC#1281

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #44576
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
RafaelGSS pushed a commit to nodejs/node that referenced this pull request Sep 26, 2022
- updated based on decision to use node: prefix in
  nodejs/TSC#1206
- updated based on agreement in TSC meeting
  on adding /promises to existing modules as per
  minutes - nodejs/TSC#1281

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #44576
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
RafaelGSS pushed a commit to nodejs/node that referenced this pull request Sep 26, 2022
- updated based on decision to use node: prefix in
  nodejs/TSC#1206
- updated based on agreement in TSC meeting
  on adding /promises to existing modules as per
  minutes - nodejs/TSC#1281

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #44576
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
juanarbol pushed a commit to nodejs/node that referenced this pull request Oct 4, 2022
- updated based on decision to use node: prefix in
  nodejs/TSC#1206
- updated based on agreement in TSC meeting
  on adding /promises to existing modules as per
  minutes - nodejs/TSC#1281

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #44576
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
juanarbol pushed a commit to nodejs/node that referenced this pull request Oct 4, 2022
- updated based on decision to use node: prefix in
  nodejs/TSC#1206
- updated based on agreement in TSC meeting
  on adding /promises to existing modules as per
  minutes - nodejs/TSC#1281

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #44576
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
juanarbol pushed a commit to nodejs/node that referenced this pull request Oct 4, 2022
- updated based on decision to use node: prefix in
  nodejs/TSC#1206
- updated based on agreement in TSC meeting
  on adding /promises to existing modules as per
  minutes - nodejs/TSC#1281

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #44576
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
juanarbol pushed a commit to nodejs/node that referenced this pull request Oct 4, 2022
- updated based on decision to use node: prefix in
  nodejs/TSC#1206
- updated based on agreement in TSC meeting
  on adding /promises to existing modules as per
  minutes - nodejs/TSC#1281

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #44576
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
juanarbol pushed a commit to nodejs/node that referenced this pull request Oct 7, 2022
- updated based on decision to use node: prefix in
  nodejs/TSC#1206
- updated based on agreement in TSC meeting
  on adding /promises to existing modules as per
  minutes - nodejs/TSC#1281

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #44576
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
juanarbol pushed a commit to nodejs/node that referenced this pull request Oct 10, 2022
- updated based on decision to use node: prefix in
  nodejs/TSC#1206
- updated based on agreement in TSC meeting
  on adding /promises to existing modules as per
  minutes - nodejs/TSC#1281

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #44576
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
juanarbol pushed a commit to nodejs/node that referenced this pull request Oct 11, 2022
- updated based on decision to use node: prefix in
  nodejs/TSC#1206
- updated based on agreement in TSC meeting
  on adding /promises to existing modules as per
  minutes - nodejs/TSC#1281

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #44576
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
- updated based on decision to use node: prefix in
  nodejs/TSC#1206
- updated based on agreement in TSC meeting
  on adding /promises to existing modules as per
  minutes - nodejs/TSC#1281

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs/node#44576
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
- updated based on decision to use node: prefix in
  nodejs/TSC#1206
- updated based on agreement in TSC meeting
  on adding /promises to existing modules as per
  minutes - nodejs/TSC#1281

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: nodejs/node#44576
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Danielle Adams <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants