Skip to content

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 8, 2023

It seems that the working group can function as a GitHub team.

Closes: #1081

@Trott
Copy link
Member Author

Trott commented Mar 8, 2023

Feel free to close this if the situation has changed or there otherwise is not consensus that this is the right thing to do. (I expect @RafaelGSS in particular to have a strong "yes" or "no" opinion on this.) Let's close #1081 once whatever decision we arrive at is made.

@Trott
Copy link
Member Author

Trott commented Mar 8, 2023

@nodejs/tsc @nodejs/security-wg

Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems there are a fair bit of drive-by fixes above the deleted lines?

@Trott
Copy link
Member Author

Trott commented Mar 8, 2023

It seems there are a fair bit of drive-by fixes above the deleted lines?

Yes. I can remove them and put them in a separate PR if that's preferable.

@mcollina
Copy link
Member

mcollina commented Mar 9, 2023

I think so. By their charter the security working group is responsible for keeping the node cves up-to-date. However, this is now done by the security steward.

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott added 2 commits March 20, 2023 17:34
It seems that the working group can function as a GitHub team.

Closes: #1081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-charter the Ecosystem Security WG
7 participants