-
-
Notifications
You must be signed in to change notification settings - Fork 138
doc: add minutes for meeting Aug 8 #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
meetings/2018-08-08.md
Outdated
### nodejs/node | ||
|
||
* Collaborator nomination - gdams [#21934](https://github.com/nodejs/node/issues/21934) | ||
* Discussed last meeting. Michael will look to ongoard George soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking nit: ongoard
-> onboard
meetings/2018-08-08.md
Outdated
* Matteo, it was a an unrelated change and the problem was an unrelated consequence | ||
* Arguably a SemVer major break in the middle of 10.x, so we should consider | ||
fixing in 10.x | ||
* Jermiah, ideally accept change in later Major, but preserve functionality for LTS. No easy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jermiah
-> Jeremiah
meetings/2018-08-08.md
Outdated
* Matteo even if its SemVer major would want to see if we can get it back | ||
into 10.x | ||
* Myles, was change in libuv SemVer main ? | ||
* Matteo, it was a an unrelated change and the problem was an unrelated consequence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a an
-> an
meetings/2018-08-08.md
Outdated
* Jeremiah, even if we do should be semver major? | ||
* Matteo even if its SemVer major would want to see if we can get it back | ||
into 10.x | ||
* Myles, was change in libuv SemVer main ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove space before ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some nits but they can be ignored if no one is feeling particularly perfectionist right now. LGTM.
No description provided.