Skip to content

doc: add minutes for meeting Aug 8 #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 22, 2018
Merged

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Aug 8, 2018

No description provided.

### nodejs/node

* Collaborator nomination - gdams [#21934](https://github.com/nodejs/node/issues/21934)
* Discussed last meeting. Michael will look to ongoard George soon.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking nit: ongoard -> onboard

* Matteo, it was a an unrelated change and the problem was an unrelated consequence
* Arguably a SemVer major break in the middle of 10.x, so we should consider
fixing in 10.x
* Jermiah, ideally accept change in later Major, but preserve functionality for LTS. No easy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jermiah -> Jeremiah

* Matteo even if its SemVer major would want to see if we can get it back
into 10.x
* Myles, was change in libuv SemVer main ?
* Matteo, it was a an unrelated change and the problem was an unrelated consequence
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a an -> an

* Jeremiah, even if we do should be semver major?
* Matteo even if its SemVer major would want to see if we can get it back
into 10.x
* Myles, was change in libuv SemVer main ?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove space before ?

Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nits but they can be ignored if no one is feeling particularly perfectionist right now. LGTM.

@mhdawson mhdawson merged commit 89fd94d into nodejs:master Aug 22, 2018
@mhdawson mhdawson deleted the meeting8Aug branch August 14, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants