Skip to content

Symbol.hasInstance support in JSRT #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jasongin opened this issue Apr 24, 2017 · 1 comment
Closed

Symbol.hasInstance support in JSRT #236

jasongin opened this issue Apr 24, 2017 · 1 comment

Comments

@jasongin
Copy link
Member

After updating the Node-ChakraCore JSRT implementation, addons_napi/test_instanceof fails because Symbol.hasInstance is not handled by either JsInstanceOf() or the JSRT napi_instanceof() implementation.
@jasongin jasongin mentioned this issue Apr 24, 2017
Merged
@jasongin jasongin mentioned this issue May 8, 2017
Merged
3 tasks
kfarnung added a commit to kfarnung/node-chakracore that referenced this issue Jun 7, 2017
@kfarnung
test: disable N-API test
326c7b9 
The test failure is being tracked by
nodejs/abi-stable-node#236
@kfarnung kfarnung mentioned this issue Jun 7, 2017
Merged
2 tasks
kfarnung added a commit to kfarnung/node-chakracore that referenced this issue Jun 7, 2017
@kfarnung
test: disable N-API test
a7fc0fe 
The test failure is being tracked by
nodejs/abi-stable-node#236

PR-URL: nodejs#288
Reviewed-By: Kunal Pathak <[email protected]>
@mhdawson
Copy link
Member

mhdawson commented Nov 15, 2021 •
edited
Loading

Closing since Chakra is no longer active, please let us know if you think that was not the right thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mhdawson @jasongin