-
-
Notifications
You must be signed in to change notification settings - Fork 170
Update binutils for OpenSSL asm support #1229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
OK .. this is going to be a problem .. the cc-armv6 and cc-armv7 machines are doing cross compiling and 2.25 is the highest we have access to for that, at least from the raspbian tools distribution. We may need to go sniffing out a new toolchain for this. I don't know enough about this to know whether we can just drop in a new custom version of debian8 and ubuntu1404 might be tricky. I'll have to go hunting down a solution for that. Unfortunately we're also using debian8 currently to build armv6 and armv7 binaries as well, they are not cross-compiled over there so that's another complication. smartos15-64 we can retire. ppcle-ubuntu1404 and rhel72-s390x are in @mhdawson and @gibfahn's hands. |
After spending way too many hours yesterday trying too begin shaving this yak, I'm coming to the conclusion that this busts our minimum compiler requirements and potentially even pushes out our minimum supported linux versions for some of our binaries. @shigeki do you know the scale of the performance cost that no-asm imposes on binaries? @jasnell IMO this puts 10.0.0 release timeline at risk, there's too many infra things to figure out here and limited brain cells and hours available to sort it out |
Orders of magnitude for things like AES on architectures with hardware support. |
@bnoordhuis I suppose ARMv6 and ARMv7 wouldn't have much hardware crypto support so would it make much difference for those? |
IIRC, AES-NI is supported aarch64. But actually GNU as version requirements mainly need for x86-64 not for ARMv6/v7 but it gets too complex to have both architecture and assembler version dependencies. Another remedy is to have asm_obsolete as we did in openssl-1.0.2 of https://github.com/nodejs/node/tree/v8.x-staging/deps/openssl/asm_obsolete for older assembler. |
This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made. |
In the discussion of nodejs/node#19944, we have to update binutils version in CI according to the requirements of OpenSSL-1.1.1 asm support if you make opt-in for `openssl_no_asm' option.
The new requirements are
At the current ,the following CI would be failed due to the older assembler version. Can we make update them?
The text was updated successfully, but these errors were encountered: