Skip to content

citgm builds with small-icu #1963

@richardlau

Description

@richardlau

Just noticed while editing the job config for #1959 that the CITGM job explicitly sets CONFIG_FLAGS to build small-icu:

image

We've recently made full-icu the default for master and the upcoming 13.x but the above will build Node.js in a non-default mode and probably means the CITGM run for nodejs/node#29522 didn't actually test what we thought it did ☹️.

I'll remove the explicit set after #1959 is resolved (don't want to change multiple things at once).

FYI @nodejs/releasers @nodejs/citgm

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions