github-bot: add node jenkins variables

[maclover7]

Refs: nodejs/github-bot#173
Refs: https://github.com/nodejs-private/secrets/pull/19

@phillipj, or anyone else on the infra team, would you be able to roll this (and the secrets PR) out together? I don't have access to the github-bot server

[phillipj]

This has been applied to the github-bot server and the bot restarted.

[maclover7]

@phillipj Thank you! Can you confirm that the updated credentials have been deployed properly? Here's what I'm getting in the logs after opening a new nodejs/node PR (to trigger the script) -- the bot seems to randomly restart itself before it can start up the Jenkins build:

{"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":13361,"req_id":"37efc333-635f-4ee1-90f4-1af2b3624326","pr":"nodejs/node/#21086","action":"pull_request.opened","level":30,"msg":"Emitting GitHub event","time":"2018-06-01T21:49:22.091Z","v":0}
{"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":13361,"req_id":"37efc333-635f-4ee1-90f4-1af2b3624326","pr":"nodejs/node/#21086","action":"pull_request.opened","level":20,"msg":"processing a new backport to v7","time":"2018-06-01T21:49:22.093Z","v":0}
{"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":13361,"req_id":"37efc333-635f-4ee1-90f4-1af2b3624326","pr":"nodejs/node/#21086","action":"pull_request.opened","level":20,"msg":"aborting any previous backport attempt...","time":"2018-06-01T21:49:22.094Z","v":0}
{"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":13361,"req_id":"37efc333-635f-4ee1-90f4-1af2b3624326","level":30,"res":{"statusCode":200,"header":"HTTP/1.1 200 OK\r\nX-Powered-By: Express\r\nX-Request-Id: 37efc333-635f-4ee1-90f4-1af2b3624326\r\nDate: Fri, 01 Jun 2018 21:49:22 GMT\r\nConnection: keep-alive\r\nContent-Length: 0\r\n\r\n"},"duration":13,"req":{"method":"POST","url":"/hooks/github","headers":{"host":"github-bot.nodejs.org:3333","accept":"*/*","user-agent":"GitHub-Hookshot/16abbec","x-github-event":"pull_request","x-github-delivery":"a48e1050-65e5-11e8-8457-0e018a6b5d1f","content-type":"application/json","x-hub-signature":null,"content-length":"21313"},"query":{},"remoteAddress":"::ffff:192.30.252.44","remotePort":54655},"msg":"request finish","time":"2018-06-01T21:49:22.102Z","v":0}
{"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":13361,"req_id":"37efc333-635f-4ee1-90f4-1af2b3624326","pr":"nodejs/node/#21086","action":"pull_request.opened","level":20,"msg":"updating git remotes...","time":"2018-06-01T21:49:22.121Z","v":0}
{"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":13361,"req_id":"37efc333-635f-4ee1-90f4-1af2b3624326","pr":"nodejs/node/#21086","action":"pull_request.opened","level":20,"msg":"Fetching origin\n","time":"2018-06-01T21:49:22.144Z","v":0}
{"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":13753,"level":30,"msg":"Loading: ./scripts/attempt-backport.js","time":"2018-06-01T21:49:32.964Z","v":0}
{"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":13753,"level":30,"msg":"Loading: ./scripts/display-travis-status.js","time":"2018-06-01T21:49:33.293Z","v":0}
{"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":13753,"level":30,"msg":"Loading: ./scripts/jenkins-status.js","time":"2018-06-01T21:49:33.369Z","v":0}
{"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":13753,"level":30,"msg":"Loading: ./scripts/node-subsystem-label.js","time":"2018-06-01T21:49:33.372Z","v":0}
{"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":13753,"level":30,"msg":"Loading: ./scripts/ping.js","time":"2018-06-01T21:49:33.373Z","v":0}
{"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":13753,"level":30,"msg":"Loading: ./scripts/trigger-jenkins-build.js","time":"2018-06-01T21:49:33.374Z","v":0}
{"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":13753,"level":30,"msg":"Listening on port 3333","time":"2018-06-01T21:49:33.384Z","v":0}
{"name":"bot","hostname":"infra-rackspace-debian8-x64-1","pid":13753,"req_id":"11e276f8-b5b4-4d92-be55-041f6acb2b17","level":30,"res":{"statusCode":201,"header":"HTTP/1.1 201 Created\r\nX-Powered-By: Express\r\nX-Request-Id: 11e276f8-b5b4-4d92-be55-041f6acb2b17\r\nDate: Fri, 01 Jun 2018 21:49:52 GMT\r\nConnection: keep-alive\r\nContent-Length: 0\r\n\r\n"},"duration":32,"req":{"method":"POST","url":"/node/jenkins/end","headers":{"host":"github-bot.nodejs.org:3333","user-agent":"curl/7.47.0","accept":"*/*","content-type":"application/json","content-length":"293","x-hub-signature":null},"query":{},"remoteAddress":"::ffff:169.60.150.88","remotePort":54480},"msg":"request finish","time":"2018-06-01T21:49:52.622Z","v":0}

[phillipj]

Np! I don't see anything of out the ordinary with the two new environment variables added I'm afraid.

I'm about to go on a weekend trip now, but if you're looking to debug what's happening, I'd say take advantage of the fact that merging changes to the bot's master branch rolls it out to production immediately.

[maclover7]

Fix is in nodejs/github-bot#174, turns out renamed function wasn't changed where it's called. Going to land this since @phillipj did a great job pushing this out earlier.