Skip to content

Conversation

StefanStojanovic
Copy link
Contributor

@StefanStojanovic StefanStojanovic commented Aug 1, 2024

Urgent, should land ASAP

This reverts commit 5d0639b.

The change being reverted broke test jobs on Windows in the test CI.

This breaks all PR CI runs, so the first one to approve it from @nodejs/build should land it as well. As for the fix I'm reverting, I'll go back to the implementation to find the error and open a new PR once it's fixed.

Fixes: #3848

EDIT: If there are no approvals in 1-2 hours, I'll land this myself since all PRs are effectively blocked by this.

This reverts commit 5d0639b.

The change being reverted broke test jobs on Windows in the test CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

win11-vs2022-arm64-COMPILED_BY-vs2022-arm64 failure
1 participant