bug: incorrect author attribution when base branch is force pushed

[danielleadams]

When a changelog is generated, there is an instance when the incorrect author is listed.

Steps for reproduction:

• commit author opens a pull request against a base branch
• a second person force pushes to base branch
• commit author rebases on base branch
• second person is added as a co-author on the commit
• when the changelog is generated, the second person that has been added as co-author is listed as the author

Expected result:

When the changelog is generated, the commit author should be listed as the author.

[targos]

Do you have an example PR for which it happened?

[RafaelGSS]

I think the issue might be on the git node land that included the wrong metadata. Just a guess.

@targos this one nodejs/node#44256

[richardlau]

I don't believe changelog-maker even looks at co-authors. commit-stream (which we're using) does parse them (since nodejs/commit-stream#4) but puts them in an authors field (plural) while changelog-maker only reads the author (singular) field:

changelog-maker/commit-to-output.js

Line 82 in 1462378

s += data.author ? `(${cleanMarkdown(data.author)}) ` : ''

changelog-maker/commit-to-output.js

Line 105 in 1462378

data.author = (commit.author && commit.author.name) || ''

[targos]

I don't think this is related to our tooling. The PR author probably did a mistake when they rebased.

[danielleadams]

Okay, I can close then.